Giters

felixfontein / acme-certificate

A **DEPRECATED** Ansible role template for using Let's Encrypt to issue TLS/SSL certificates which requires no code to be run on your webserver.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

cleanup files more safely

drzraf opened this issue · comments

commented

issue-certs-cleanup.yml cleanups {server_location} without any guards (in case of role misuse)
If server_location is not set it will remove * file in the current directory or worst if set to /var/www/
server_location should be given a sane default value (/tmp/www-challenges) and use the |default() construct for maximal safety.

commented

If server_location is not set, it should complain that server_location is not defined and bail out instead of executing this. (And so far ansible always died when I tried to use an undefined variable.)

Anyway, taking a default for server_location does make no sense at all since that path MUST be integrated in your (web) server configuration, otherwise the whole process won't work.

Anyway, using file: dest="{{ server_location }}" state=absent might be a better example for this role. This will also complain in case server_location would be set to an empty string.