Giters

felipepenha / py-greenhouse

A containerized Python framework for a better Data X development workflow. Where X = Science, Engineering, Analytics, etc.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add logs folder to the gitignore

gdiepen opened this issue · comments

commented

The logs folder will be modified every time that you do a run. Even if you did not make any changes in your code, the new timestamps will result in modified files in the log file which results in a lot commits

commented

I agree and I see 3 points where sending logs to git may have been a bad design choice:

  • logs are modified with every run, even when code is not changes;
  • multiple users changing code in parallel will result in logs that are inconsistent;
  • I am opening up the possibility of data leakage.

I will proceed and include the logs sub directory in the .gitignore file, so logs are kept only locally.

commented

I will also delete the current logs.

commented

Issue is being closed.

I was facing the problem that the logs were still being sent to the remote branch, but I solved it by running first

git rm --cached [file]

for each of the log files, because they were already being tracked.