reserved identifier violation

Question

reserved identifier violation

elfring opened this issue 4 years ago · comments

I would like to point out that identifiers like “_ASTEROID_H_” and “_BUILDING_H_” do not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?

fegennari · Answer 1 · Fri Mar 20 2020 16:04:17 GMT+0800 (China Standard Time)

Thanks. I wasn't aware of the underscore naming convention rules. I've never run into a problem with this before. It's probably best to change all 66 headers to use "#pragma once" instead of these macro include guards to match the newer headers that already do it this way. That took a while but it's committed.

Markus Elfring · Answer 2 · Fri Mar 20 2020 16:14:21 GMT+0800 (China Standard Time)

The construct “#pragma once” is not standard compliant.

fegennari · Answer 3 · Fri Mar 20 2020 16:24:48 GMT+0800 (China Standard Time)

Interesting. I wasn't aware of that either. I have been using this in both Visual Studio and gcc for a while now without problems. I've had "#pragma once" in 3DWorld for about two years now in some of the newer header files. While it may not be standard compliant, I prefer to leave it in until I run into an actual problem. Also, because it's been in use in other files, I don't consider this change a regression. Maybe I'll get back to this later. Thank you.