feedzai / fairgbm

Train Gradient Boosting models that are both high-performance *and* Fair!

Home Page:https://arxiv.org/abs/2209.07850

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[refactor] Cannot have code changes in `auto_config.cpp` - will be overriden

AlbertoEAF opened this issue · comments

I just found out this file helpers/parameter_generator.py, which states at the beginning:

This script generates LightGBM/src/io/config_auto.cpp file
with list of all parameters, aliases table and other routines
along with parameters description in LightGBM/docs/Parameters.rst file
from the information in LightGBM/include/LightGBM/config.h file.

meaning all the changes in config_auto that are done currently in fairgbm need to be moved out of there to the original LightGBM/include/LightGBM/config.h file.

I'll leave here a couple of required changes to the configs:

image

and:

image

Update: all code changes have been ported to the config.h file (we still need if there are any errors when parsing/compiling it to the generated config_auto.cpp).

FairGBM parameters need to be defined in order for this task to be completed.