featurevisor / featurevisor

Feature flags, experiments, and remote config management with GitOps

Home Page:https://featurevisor.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Suggestion: Disable Automatic Deployments in Cloudflare

meirroth opened this issue · comments

I followed the integration guide provided at CI/CD guides: Cloudflare Pages to set up my project using GitHub Actions and deployed it to Cloudflare. The setup worked like a charm. However, I noticed that Cloudflare has Automatic Deployments turned on by default. This led to a conflict where Cloudflare initiated a deployment upon merging a pull request, causing the GitHub publish Action to fail.

Would it be a good idea to update the documentation advising users to turn off Automatic Deployments to prevent such conflicts?

Also, a huge thumbs up for the awesome documentation! It's been incredibly useful, and I'm looking forward to leveraging it for my project.

that's awesome to hear! thanks for the kind feedback, @meirroth.

would be very happy if you can send a PR to update the docs, which are all managed from this repository as well.

you can find the cloudflare doc here: https://github.com/featurevisor/featurevisor/blob/main/docs/integrations/cloudflare-pages.md

irrespective of Cloudflare, it's possible that multiple PRs might be merged very quickly, and simultaneously triggered workflows may fail trying to push back the version/revision commit to your repo.

here's a section that shows how that problem can be tackled with GitHub Actions: https://featurevisor.com/docs/integrations/github-actions/#sequential-builds

@fahad19 Sure! Opened a PR.