FeathersVuexGet component doesn't work with params

[Guillaume Mercey]

Steps to reproduce

<template>
  <FeathersVuexGet
    v-slot="{ item: user }"
    service="users"
    :id="id"
    :fetch-params="{ query : { $eager: '[profile]' } }"
  >
     <pre> {{ user }} </pre>
  </FeathersVuexGet>
</template>

...

id: 42

Expected behavior

User object with nested profile object

Actual behavior

User object is empty.
The component works fine without params.
The query return the expected results without the component.

The issue is how the component use the store getters. According to the documentation fetchParams is only used for the API for the API server, and the component should only use the resource id on the store getters. But currently, params and fetchParams are used in the same way:

feathers-vuex/src/FeathersVuexGet.ts

Lines 119 to 121 in 4ae03ba

 getArgs(queryToUse) { 
   const query = queryToUse || this.fetchQuery || this.query 
   const params = this.fetchParams || this.params 

Because the params are passed to the store getters, the store returns null.

feathers-vuex/src/FeathersVuexGet.ts

Lines 95 to 105 in 4ae03ba

 const getArgs = this.getArgs(this.query) 
 if (this.id) { 
   if (getArgs.length === 1) { 
     return this.$store.getters[`${this.service}/get`](this.id) || null 
   } else { 
     const args = [this.id] 
     const query = getArgs[1].query 
     if (query) { 
       args.push(query) 
     } 
     return this.$store.getters[`${this.service}/get`](args) || null 

getArgs return [0: 42, 1: { query : { $eager: '[profile]' }}] and the query is passed as args to the store getters.

Replacing

return this.$store.getters['${this.service}/get'](args) || null

by

return this.$store.getters['${this.service}/get'](this.id) || null

produce the expected results confirming the issue.

System configuration

Latest version of the package.

[Marshall Thompson]

Oh, good point! If you want to make a PR to separate them, I'll accept it. I don't have the ability to focus on this right now.

Thanks for the excellent bug report.