feathers-plus / generator-feathers-plus

A Yeoman generator to (re)generate a FeathersJS application supporting both REST and GraphQL architectural concepts and their query languages.

Home Page:https://generator.feathers-plus.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

With no semicolon option generator adds semicolons

MarcGodard opened this issue · comments

Steps to reproduce

Create services that are custom, with the option for semicolon as false:

  "options": {
    "ver": "1.0.0",
    "inspectConflicts": false,
    "semicolons": false,
    "freeze": [
      ".eslintrc.json"
    ],
    "ts": false
  }

and eslintrc.json as (must be frozen to keep the semi option required by IDE:

{
  "env": {
    "es6": true,
    "node": true,
    "mocha": true
  },
  "parserOptions": {
    "ecmaVersion": 2017
  },
  "extends": "eslint:recommended",
  "rules": {
    "indent": [
      "error",
      2
    ],
    "linebreak-style": [
      "error",
      "unix"
    ],
    "quotes": [
      "error",
      "single"
    ],
    "semi": [
      "error",
      "never"
    ]
  }
}

When I regenerate my app, or any services, semicolon get added to some modules (custom ones) on the last line like this:

module.exports = moduleExports;

This is just annoying as I have to discard those changes before committing code or running the app as they cause errors.

Expected behavior

Semicolons should not appear when semicolons are set to false.

Actual behavior

Semicolons show up when regenerating.

System configuration

Tell us about the applicable parts of your setup.

Module versions
feathers-plus --version 0.8.10

NodeJS version:
All tested versions.

Operating System:
Mac os

Browser Version:
N/A

React Native Version:
N/A

Module Loader:
N/A