Giters

fdivitto / FabGL

ESP32 Display Controller (VGA, PAL/NTSC Color Composite, SSD1306, ST7789, ILI9341), PS/2 Mouse and Keyboard Controller, Graphics Library, Sound Engine, Game Engine and ANSI/VT Terminal

Home Page:http://www.fabglib.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

WINDOWSIZE not set correctly by NetworkTerminal

mobluse opened this issue · comments

commented

The WINDOWSIZE is reported to the Telnet server to be 80x25 even though it is 80x34, in my case. This is a problem if you run more/less or edit files with e.g. nano, because e.g. less scrolls to little and nano doesn't use the whole screen.

I fixed this in a general way in my fork of FabGL NetworkTerminal.ino. It uses Terminal.getRows(). I could send a PR, but you don't want PRs. The fix is in exe_telnet(). Maybe this could be fixed in a way that is faster or consumes less RAM. I'm open to suggestions. There are also other modifications of the original in my fork.