CE 3.5.0 async cancelation semantics

Question

CE 3.5.0 async cancelation semantics

Jasper-M opened this issue a year ago · comments

I think fs2-kafka will require some changes to accommodate the new async cancelation semantics in the upcoming CE 3.5.0.

For instance this timeout will probably be rendered useless. Also I suspect that currently this timeout only cancels the waiting on the callback but will leak the actual hanging commit, which is what those new semantics are guarding against.

Ben Plommer · Answer 1 · Tue Apr 11 2023 19:06:09 GMT+0800 (China Standard Time)

Thanks for flagging this! I'm on it.

Ben Plommer · Answer 2 · Tue Apr 11 2023 19:50:50 GMT+0800 (China Standard Time)

Also I suspect that currently this timeout only cancels the waiting on the callback but will leak the actual hanging commit, which is what those new semantics are guarding against.

Yes, you're right - unfortunately I don't think there's anything we can do about that unless we revert to using the commitSync method which has an optional timeout parameter.

Jasper Moeys · Answer 3 · Wed Jul 19 2023 17:03:22 GMT+0800 (China Standard Time)

I guess this is fixed, but github didn't close it for some reason?