faucet-pipeline / aiur

a simple styleguide generator

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Figure out where URIs should come from

moonglum opened this issue · comments

Where are URIs being generated now? I've noticed Navigation concatenates baseURI and slug, so the lack of encapsulation makes me uncomfortable once more (based on actual real-world experience).

Having said that: It's probably not important right now; we'll deal with it if and when it comes up during actual use.

aiur's entry point (i.e. index.js) passes baseURI (optional?¹ configuration) to Site which in turn passes it through to Navigation in order to make it available to Navigation#item. It looks like that method is the only place where baseURI is actually being used, so the entire pass-through dance seems smelly. On the upside, that should make it relatively straightforward to restore encapsulation.²

¹ Looks like cli.js sets a default - though that seems odd; such global defaults should be defined by whichever module assumes primary responsibility for the respective value (cf. prior faucet discussions in that vein).

² Site should probably assume responsibility for URIs; cf. ac689aa.