mipsle arch is missing softfloat flag due to Makefile.cross-compiles bug
ddscentral opened this issue · comments
Bug Description
In Makefile.cross-compiles even though both mips and mipsle have softfloat flag, it is only applied for "mips" due to a bug in "if statement.
Line
elif [ "$${os}" = "linux" ] && [ "$${arch}" = "mips" ] && [ "$${extra}" != "" ] ; then \
should look like this:
elif [ "$${os}" = "linux" ] && ([ "$${arch}" = "mips" ] || [ "$${arch}" = "mipsle" ]) && [ "$${extra}" != "" ] ; then \
frpc Version
0.57.0
frps Version
0.57.0
System Architecture
linux/mipsel
Configurations
Not applicable
Logs
No response
Steps to reproduce
- Run make -f Makefile.cross-compiles
- Copy mipsle binary (any frps or frpc) to a MIPS device without a FPU
- Binary does not run due to "illegal instruction".
Affected area
- Docs
- Installation
- Performance and Scalability
- Security
- User Experience
- Test and Release
- Developer Infrastructure
- Client Plugin
- Server Plugin
- Extensions
- Others
With the line corrected, binaries do run on the device.
Can you submit a PR to fix it?
Created a PR: #4176