fastred / SloppySwiper

UINavigationController delegate that allows swipe back gesture to be started from anywhere on the screen (not just from the edge).

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

bug for UITabBarController.

xhzengAIB opened this issue · comments

Hi! @fastred
Look this picture:
slobug

Jack

I can't reproduce it, and I'm not sure why it happens because toViewController's view is inserted below the current view controller's view: https://github.com/fastred/SloppySwiper/blob/master/Classes/SSWAnimator.m#L48

Maybe there's a bug in SSWAnimator but I'm not seeing it right now.

Can you see if it's happening on the physical device too?

@fastred
Ok! I try it.

Hi! @fastred
I running on iPhone4, this bug appear.

Jack

@fastred
I use this open source(https://github.com/xhzengAIB/MessageDisplayKit) and your open source running on my iPhone4, bug appear.

Jack

@fastred
Translation speed not right and the view layers not right.

Thanks for preparing the example. I tested it out and it seems to me that hidesBottomBarWhenPushed doesn't work with custom transitions (I reported it as rdar://17093531).

Here's what happens if I remove all transforms from animateTransition: in SSWAnimator:
2014-06-02 17_45_11

UITabBar slides in independently of the previous view controller's view animations (or lack of thereof). One way of fixing it would be to change the view controller hierarchy by embedding UITabBarController inside of UINavigationController. With this hierarchy you wouldn't have to use hidesBottomBarWhenPushed:
screenshot 2014-06-02 17 52 15

@fastred
Ok! I try it.

I added info about this issue to README in bae450e
I'm not sure anything else can be done to fix it at the moment.

hi!you fix the bug for tabbarcontroller insert to navigationcontroller?

No, but as I wrote earlier:

  • I added a note in README: bae450e
  • I reported this bug to Apple: rdar://17093531

Do you have any ideas how to fix this issue?

@fastred
I think should be provided by the apple API is not enough, may be need to apple's support, to solve this issue further.

Jack

Any further developments on this issue?

You can work around this issue by changing the view controller hierarchy, as I showed in #2 (comment)

The radar is still open.

I have written the same interaction effect 5 months ago, and deal with the issue when navigationbar hidden or tabbar hidesBottomBarWhenPushed.
my repo https://github.com/wangyang10/CustomPopAnimation

Should be fixed in #6

Hey, @fastred
I forked this repo and work out this issue.
Here is the address of my repo: https://github.com/yinnieryou/SloppySwiper
I don't know my solution is suitable for you or not, it works perfect on my project.

sloppyswiper

Hi. Scrollview not working after push and back to the controller