12.9-inch iPad Pro (3rd Gen) is missing
appcornerit opened this issue · comments
Hi, Apple metadata rejected due 12.9-inch iPad Pro screenshots do not display the app in the correct device frame, iPad Pro (3rd Gen) doesn't have the home button.
Is there a way to force the device frame by Apple?
Thanks.
12.9-inch iPad Pro (3rd Gen) is missing
Yes, that device is unfortunately not present with the device frames this is using: https://facebook.design/devices
For your other question(s), you should open an issue at https://github.com/fastlane/fastlane/issues
Same issue. Hope for alternative solution soon.
Automate
curl https://user-images.githubusercontent.com/586910/59685084-413aa480-91d3-11e9-9d1f-2c943317f650.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Space\ Gray.png
# I use WHITE, so I had to add Silver as well while it is the same
# let me know if you have a white frame
curl https://user-images.githubusercontent.com/586910/59685084-413aa480-91d3-11e9-9d1f-2c943317f650.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Silver.png
# Remove last two lines
sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
cat >> ~/.fastlane/frameit/latest/offsets.json <<EOL
,
"iPad Pro (12.9-inch) (3rd generation)": {
"offset": "+119+216",
"width": 2048
}
}
}
EOL
If you don't need this black line (home slider) or has screenshots in landscape mode, you can use latest (29 sept 2019) device mockups from Facebook.
Offset was adjusted and looks fine for me, but i'm not sure it's pixel accurate
curl https://user-images.githubusercontent.com/24507532/66273840-689ba700-e880-11e9-95e6-7ecb63728b2c.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Space\ Gray.png
curl https://user-images.githubusercontent.com/24507532/66273839-66394d00-e880-11e9-85cf-50f4dc0210c5.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Silver.png
# Remove last two lines
sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
cat >> ~/.fastlane/frameit/latest/offsets.json <<EOL
,
"iPad Pro (12.9-inch) (3rd generation)": {
"offset": "+200+200",
"width": 2048
}
}
}
EOL
When the 3rd Gen iPad Pro is added to facebook device library , it could be also properly integrated into fastlane frameit, because fastlane is using this device library. The new iPhones could be added as well!
@ConfusedVorlon where did the image you posted above come from?
@ConfusedVorlon where did the image you posted above come from?
You can find mockups there - https://facebook.design/devices
When running frameIt it doesn't pickup those images shown above with he curl statement :(
If you don't need this black line (home slider) or has screenshots in landscape mode, you can use latest (29 sept 2019) device mockups from Facebook.
Offset was adjusted and looks fine for me, but i'm not sure it's pixel accurateMockups (Space Gray & Silver)
curl https://user-images.githubusercontent.com/24507532/66273840-689ba700-e880-11e9-95e6-7ecb63728b2c.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Space\ Gray.png curl https://user-images.githubusercontent.com/24507532/66273839-66394d00-e880-11e9-85cf-50f4dc0210c5.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Silver.png # Remove last two lines sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json cat >> ~/.fastlane/frameit/latest/offsets.json <<EOL , "iPad Pro (12.9-inch) (3rd generation)": { "offset": "+200+200", "width": 2048 } } } EOL
Any further suggestions, I can’t get this to work now, it says it can’t find the 3rd gen item?
@ConfusedVorlon Have you ran FrameIT for this device recently?
@ConfusedVorlon Have you ran FrameIT for this device recently?
not a clean version of FrameIt. (I think it is using my frame at the moment)
OK, I've solved my problem, I think I must have had an old version of frameit installed, perhaps and uninstall and reinstall may have fixed this. However I've got some different paths, I also needed to diff my offsets file.
/Users/jm/.fastlane/frameit/latest/
~/.frameit/devices_frames_2/latest/
If you don't need this black line (home slider) or has screenshots in landscape mode, you can use latest (29 sept 2019) device mockups from Facebook. Offset was adjusted and looks fine for me, but i'm not sure it's pixel accurate
Mockups (Space Gray & Silver)
curl https://user-images.githubusercontent.com/24507532/66273840-689ba700-e880-11e9-95e6-7ecb63728b2c.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Space\ Gray.png curl https://user-images.githubusercontent.com/24507532/66273839-66394d00-e880-11e9-85cf-50f4dc0210c5.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Silver.png # Remove last two lines sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json cat >> ~/.fastlane/frameit/latest/offsets.json <<EOL , "iPad Pro (12.9-inch) (3rd generation)": { "offset": "+200+200", "width": 2048 } } } EOL
This did not work for me because frameit replaced '-' with ' ', which then leads to the program not being able to find the '12.9-inch' part of the string. Instead I used:
curl https://user-images.githubusercontent.com/24507532/66273840-689ba700-e880-11e9-95e6-7ecb63728b2c.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Space\ Gray.png
curl https://user-images.githubusercontent.com/24507532/66273839-66394d00-e880-11e9-85cf-50f4dc0210c5.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Silver.png
# Remove last two lines
sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
cat >> ~/.fastlane/frameit/latest/offsets.json <<EOL
,
"iPad Pro (12.9 inch) (3rd generation)": {
"offset": "+120+206",
"width": 2048
}
}
}
EOL