FastfileParser should implement a `.to_json` method.

Question

FastfileParser should implement a `.to_json` method.

minuscorp opened this issue 6 years ago · comments

Jorge Revuelta commented 6 years ago

Title says it all.

Felix Krause · Answer 1 · Wed Mar 21 2018 00:38:04 GMT+0800 (China Standard Time)

What for? :)

Jorge Revuelta · Answer 2 · Wed Mar 21 2018 03:34:09 GMT+0800 (China Standard Time)

So for peeking Fastfile configurations to the front-end, now I have to generate a custom json from the FastfileParser (such as sanitizing lanes with no platform, or functions being declared out of platform scope, pure ruby methods, etc). And pass it to the front end.

Felix Krause · Answer 3 · Wed Mar 21 2018 03:36:18 GMT+0800 (China Standard Time)

Wouldn't parser.all_lanes_flat.to_json be enough?

Jorge Revuelta · Answer 4 · Wed Mar 21 2018 03:52:40 GMT+0800 (China Standard Time)

Except from when the platform is nil, that should've replaced for some recognizable key (for now I'm using :no_platform when platform is nil.
all_lanes_flat seems to be able to ignore actions out of a platform scope, but I don't know if that's something it should be like that (are we allowing to run lanes out of platform in CI?)