Use of legacy DELIVER_* in password_manager.rb
timsutton opened this issue · comments
I'm doing some testing with the 1.1.0 gem release of XcodeInstall, which uses CredentialsManager 0.10.0.
The CredentialsManager docs mention to set the new FASTLANE_* variables, but in password_manager.rb there is still the use only of DELIVER_*. As far as I can tell, I still get a prompt if PasswordManager is initialized with only the FASTLANE_* vars set.
@timsutton The PasswordManager isn't used anywhere any more and also shouldn't be used by XcodeInstall.
FASTLANE_* should work just fine
You're right, it doesn't use this directly - XcodeInstall uses Spaceship. It looked to me like in my testing that if I didn't have DELIVER_* vars set, that I would get a keychain-related prompt that was blocking a CI environment build script that I'm testing. When I didn't get the prompt upon replacing FASTLANE_* with DELIVER_* I assumed this was the reason. I'll have to go back and test this again. The fastlane "ecosystem" is all very new to me.
Okay cool 👍
Thanks for letting me know @timsutton
This issue was migrated to fastlane/fastlane#3318. Please post all further comments there.
fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo 🚀