Giters

fastify / website

Home Page:https://fastify.dev/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Integrate search plugin

Eomm opened this issue · comments

commented

We need the search button integrated into the website

Image

🚀 As an exploration, we could try Lyra first: https://github.com/LyraSearch/plugin-docusaurus
It is a local and in-memory search, so it does not require any additional step or external system 🔝

If blocking issues are found on the first step, the current online website has the algolia plugin to enable the "search" button.
This plugin is already integrated into docusaurus. It requires some config only and keys (need to generate a key pair cc @lmammino ).

commented

Can I take a look at this?

commented

No, sorry, I forget to update this issue.

I already started to test it, but I found some bugs/required features:

Here is the branch that I'm working on: https://github.com/fastify/website-next/tree/lyra

commented

After the POC #63 I think the lyra plugin is not yet ready to be integrated - the first release will use algolia

commented

@mcollina this is the last issue before considering the migration complete.

I think we could setup the fastify.dev to point to https://fastify.github.io/website-next/
I'm not into the fastify team in algolia, could you invite me or provide the keys?

commented

I would really prefer to use Orama / avoid any external service for this. The configuration of Algolia is so painful that anything local would be better long term.

@Eomm I've invited you to algolia

commented

I did the check, and the plugin is not mature enough at this time #28 (comment)

For sure we will switch to it

commented

Meilisearch could be an alternative too. It is open source and as far as I have tested it works like a charm. Would have to dig into the integration with Docusaurus though..

commented

@mcollina @Eomm I can work on Orama integration in couple of weeks, if you can wait. Once I'll back from OpenJS I should be able to send a PR.

commented

@ShogunPanda Any news on this topic?

commented

@Eomm I'm pretty packed these days. I plan to do that within Friday. Probably Thursday or Friday itself.

commented

@mcollina @Eomm FYI, I'm currently working on this. I've fixed some problems with styling and hooks and now I'm taking care of versioning.

I hope to have news in few days.

commented

As soon askorama/orama#404 lands I should be able to provide you a PR on this.
Note that I focused on basic styling functionality so I leave personalization to you.

commented

Note that I focused on basic styling functionality so I leave personalization to you.

This scares me a lot 🤣

commented

Note that I focused on basic styling functionality so I leave personalization to you.

This scares me a lot 🤣

That's exactly my purpose. Lol.

commented

@mcollina @Eomm The PR is here finally. Enjoy!