unusable in tests

Question

unusable in tests

mcollina opened this issue 7 years ago · comments

watch mode is always enabled, but this will cause the process to hang during tests and wait.
Passing watch: false as an options solves it.

Maybe we should have that set as a default, and accept watch: true. This would be the reverse to what bankai does.

Tomas Della Vedova · Answer 1 · Thu Jun 22 2017 14:49:15 GMT+0800 (China Standard Time)

Nice catch, now I understood why I had to put this at the end of the test.
I agree with you that watch by default must be false for a better usability in our context.

@yoshuawuyts just out of curiosity, why in bankai watch is true by default?

Yosh · Answer 2 · Fri Jun 23 2017 06:37:20 GMT+0800 (China Standard Time)

Err, felt it made sense to have it watch by default - main use case for was recompiling and serving assets; not having it watch would probably feel a bit weird haha

…

On Thu, Jun 22, 2017 at 7:49 AM Tomas Della Vedova ***@***.***> wrote: Nice catch, now I understood why I had to put this <https://github.com/fastify/fastify-pigeon/blob/master/test.js#L102> at the end of the test. I agree with you that watch by default must be false for a better usability in our context. @yoshuawuyts <https://github.com/yoshuawuyts> just out of curiosity, why in bankai watch is true by default? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWlet3vCGxDifXtg2vEVm-ds0GBMXukks5sGg5rgaJpZM4OBlUJ> .

Matteo Collina · Answer 3 · Fri Jun 23 2017 06:44:04 GMT+0800 (China Standard Time)

@yoshuawuyts what would be the dev workflow with bankai, related to moving the generated stuff to prod?

Yosh · Answer 4 · Fri Jun 23 2017 07:57:20 GMT+0800 (China Standard Time)

Generally I use bankai from the CLI and upload it to nginx somehow - if I were to run it on a server directly I'd probably turn off live reload, and let nginx + CDNs take care of it. Hope this makes sense?

…

On Thu, Jun 22, 2017 at 11:44 PM Matteo Collina ***@***.***> wrote: @yoshuawuyts <https://github.com/yoshuawuyts> what would be the dev workflow with bankai, related to moving the generated stuff to prod? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWlel0N8PEJpSBW686U8P-nEVDZM-HPks5sGu42gaJpZM4OBlUJ> .