Giters

fastify / deepmerge

Merges the enumerable properties of two or more objects deeply. Fastest implementation of deepmerge

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

The reason behind the `all` option

Songkeys opened this issue · comments

commented

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

I'm curious about the purpose of the all option. From the code, it appears that _deepmergeAll is the same as _deepmerge when two arguments are present, but can also be used for other n-argument cases. Could we use _deepmergeAll as the default option? Have I overlooked something?

commented

The typescript typings are recursively determining the final object shape and thus can slow down your typescript transpilation and your IDE, like vscode.

commented

Oh yes. I forgot about the typescript typing. Is ...args: T[] an option to solve this alternatively btw?

Meanwhile I think we should state clearly in the doc. The current description is too vague about this option.

commented

You can provide a PR if you like.