Redis Cluster/Sentinel
james-d-elliott opened this issue · comments
From what I can tell from the upstream library, you need to instantiate a client with NewClusterClient/NewSentinelClient in order to setup connections to these types, I've not confirmed this. But was wondering if you either knew before I worked on supporting something like this, and if you had a preference for how we would set it up.
I think realistically it would be better to make it their own providers since the options are vastly different for Sentinel and for Cluster configurations.
@savsgio did you have an opinion on this at all?
Hi @james-d-elliott,
Sorry for delayed answer.
The configuration of these clients are different, so you could create a separate providers for thats clients.
So if you want you could make a PR and i will review it.
It's no worries, I saw you were busy with stuff in the other fasthttp repos! I figured you saw it and forgot so just gave you a friendly ping.
Also that's what I thought the preference would be and makes sense. I'll look at implementing sometime soon.
For anyone interested in redis cluster please see the third paragraph of #38 (comment) and my commit on our downstream maintenance repo (please note this repo is not going to be maintained, it's just here so we can implement features rapidly - it will be archived soon most likely) authelia/session@db6b852