faif / python-patterns

A collection of design patterns/idioms in Python

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add Protocol to factory pattern

mfurquimdev opened this issue Β· comments

Hi πŸ‘‹πŸ½

I see we have some type hints that's been continuously added as mentioned at #373.

As the factory pattern has the constrain of both classes having to implement a localize method, I thought it might be a good idea to reinforce this constrain by using Protocol.

I'd gladly implement this if it's okay.

Here's the PEP-0544 and the Python docs for Protocols.

Hi,

Sure, go ahead.