In graph_search there's a sub optimal algorithm for shortest path

Question

In graph_search there's a sub optimal algorithm for shortest path

keobox opened this issue 4 years ago · comments

find_shortest_path can be done in linear time using BFS (Breadth First Search).
The original article mentioned in the comments in graph_serach.py is providing the code using BFS.

Also all paths can be implemented with a BFS or DFS (Depth First Search).
Here some examples in Java:
https://algs4.cs.princeton.edu/code/edu/princeton/cs/algs4/DepthFirstPaths.java.html
https://algs4.cs.princeton.edu/code/edu/princeton/cs/algs4/BreadthFirstPaths.java.html

Sakis Kasampalis · Answer 1 · Thu Jul 16 2020 05:08:57 GMT+0800 (China Standard Time)

Feel free to open a pull request with improvements. I have my doubts about whether it's better to remove the algorithms examples from this repo, since they are not design pattern related.

Lewis C Chamberlain · Answer 2 · Sun Aug 16 2020 11:53:22 GMT+0800 (China Standard Time)

I'll implement BFS in graph_search.py. The current DFS solutions are good, and I will not remove them. They'll get renamed to include "dfs" and I'll add some new methods.

Lewis C Chamberlain · Answer 3 · Thu Aug 20 2020 02:09:02 GMT+0800 (China Standard Time)

@faif, this issue was resolved with PR #350, which I made. I'm new to GitHub, is there a way I could have connected that PR to this issue?

Sakis Kasampalis · Answer 4 · Thu Aug 20 2020 04:21:21 GMT+0800 (China Standard Time)

What you did looks fine, thanks :)