Gradually add type hints to the examples

Question

Gradually add type hints to the examples

rednafi opened this issue 4 years ago · comments

A few examples (like the delegation pattern) can be difficult to understand without type hints. Unless you want to keep backward compatibility with older Python versions, adding type hints can make the intents of the code snippets clearer.

Sakis Kasampalis · Answer 1 · Fri Jun 19 2020 03:09:58 GMT+0800 (China Standard Time)

That is a good suggestion. Backward compatibility is not extremely useful, since Python 2.x has reached EOL

Redowan Delowar · Answer 2 · Fri Jun 19 2020 05:06:45 GMT+0800 (China Standard Time)

Yeah, since you can add the type hints gradually, it shouldn't be problem to convert. I've already added type checking to the delegation pattern and sent a PR.

Florian Kromer · Answer 3 · Fri Jun 19 2020 18:17:53 GMT+0800 (China Standard Time)

That is a good suggestion. Backward compatibility is not extremely useful, since Python 2.x has reached EOL

"Le roi est mort, vive le roi" 😉

Sakis Kasampalis · Answer 4 · Sat Jun 20 2020 23:24:36 GMT+0800 (China Standard Time)

Closing it since the effort has already started. Thanks @rednafi