Typo in download_dataset.py

Question

Typo in download_dataset.py

TianyuDai opened this issue 2 years ago · comments

Hi,
Thank you for making the dataset public!
I tried to download the mini-dataset following the instruction, but fell into an infinite loop.
Should line 65 in download_dataset.py be if os.path.isfile("%s.checksum" % (tar_file))?

Yuming Gu · Answer 1 · Tue Jul 26 2022 07:13:09 GMT+0800 (China Standard Time)

I had the same issues in downloading mini-dataset as well.

Yuming Gu · Answer 2 · Tue Jul 26 2022 08:04:59 GMT+0800 (China Standard Time)

And seems like both of /path/to/mini-dataset and /path/to/dataset doesn't exists?

alexanderrichard · Answer 3 · Tue Jul 26 2022 09:14:58 GMT+0800 (China Standard Time)

Apologies for the inconvenience. We will fix the bug asap.

doudou · Answer 4 · Tue Jul 26 2022 22:05:26 GMT+0800 (China Standard Time)

And seems like both of /path/to/mini-dataset and /path/to/dataset doesn't exists?

Hi, that is for you to replace with the path to your downloaded dataset. Thank you.

Cheng-hsin Emily WUU · Answer 5 · Tue Jul 26 2022 22:24:53 GMT+0800 (China Standard Time)

Hi, Thank you for making the dataset public! I tried to download the mini-dataset following the instruction, but fell into an infinite loop. Should line 65 in download_dataset.py be if os.path.isfile("%s.checksum" % (tar_file))?

Hi, Thanks for pointing this out. download_dataset.py is updated and added the condition to avoid possible infinite loop.