adlib_response_to_tables() failing on is.response(x)?

[Kyle Scot Shank]

Following code fails:

query <- adlib_build_query(ad_reached_countries = 'US', 
                           ad_active_status = 'ACTIVE', 
                           impression_condition = 'HAS_IMPRESSIONS_LAST_90_DAYS', 
                           search_terms = "healthcare")

result <- adlib_get(query = query,
                    token = token_get())

adlib_data_frame(result)

result_paginated <- adlib_get_paginated(query = query,
                                        token = token_get(),
                                        max_gets = 1)

all are failing with is.response(x) is not TRUE

[Colin Fraser]

I'll have to look into why this fails, but I am thinking of deprecating this function entirely in favor of just using as_tibble. The reason is that I think we don't want to have fetching all fields to be the default behavior in requests, because that often results in giant responses and "Try requesting less data" errors. I also think that having just the one as_tibble function is cleaner than exposing a bunch of different conversion functions. Thoughts?

…

On Sun, Dec 8, 2019, 7:14 PM Kyle Scot Shank ***@***.***> wrote: Following code fails: query <- adlib_build_query(ad_reached_countries = 'US', ad_active_status = 'ACTIVE', impression_condition = 'HAS_IMPRESSIONS_LAST_90_DAYS', search_terms = "healthcare") result <- adlib_get(query = query, token = token_get()) adlib_data_frame(result) result_paginated <- adlib_get_paginated(query = query, token = token_get(), max_gets = 1) all are failing with is.response(x) is not TRUE — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#17?email_source=notifications&email_token=AC3I5OQVMC7TF2Z2PFXRBEDQXWZX5A5CNFSM4JYCQJ22YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H66KZAQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC3I5OSXFQORMNRV2AZ665TQXWZX5ANCNFSM4JYCQJ2Q> .

[Kyle Scot Shank]

I'm aligned. Closing task and making a note to myself to update pagination files.