Should we make the dependency on keyring optional?

Question

Should we make the dependency on keyring optional?

colin-fraser opened this issue 5 years ago · comments

You can send a request by pasting a token directly into adlib_get so we don't need to require users to have keyring. It's more of a convenience and gives you security.

Kyle Scot Shank · Answer 1 · Mon Dec 09 2019 09:06:54 GMT+0800 (China Standard Time)

My vote would be to leave it as encouraged, but not required. I can make sure the documentation clearly states that using keyring is the superior option.

Colin Fraser · Answer 2 · Mon Dec 09 2019 12:06:40 GMT+0800 (China Standard Time)

Yeah I think so too. I'll have to add some error handling to make this work nicely but I think it's a good idea.

…

On Sun, Dec 8, 2019, 5:06 PM Kyle Scot Shank ***@***.***> wrote: My vote would be to leave it as *encouraged*, but not *required*. I can make sure the documentation clearly states that using keyring is the superior option. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#12?email_source=notifications&email_token=AC3I5ORJR5DVHLNRCDYGO4LQXWK25A5CNFSM4JYBG562YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGHQTFI#issuecomment-563022229>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC3I5OUVGXJCXUJYSBZO7HTQXWK25ANCNFSM4JYBG56Q> .