facebookincubator / velox

A composable and fully extensible C++ execution engine library for data management systems.

Home Page:https://velox-lib.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Refactor ParquetReader initializeSchema.

majetideepak opened this issue · comments

Description

The ParquetReader initializeSchema needs a refactor. There are too many branches and special cases.
https://github.com/facebookincubator/velox/blob/main/velox/dwio/parquet/reader/ParquetReader.cpp#L233

It was also hard to investigate this in production since standard exceptions are only caught in the TableScan operator. We need to add a standard exception check at the Parquet Parser level.

Remaining part of #11589