Auto-detect more common editors

[dan]

Let's send PRs for autodetecting more common editors for the error overlay!
The feature already works both on macOS and Windows (thanks @levrik).

Currently detected editors are here:

const COMMON_EDITORS_OSX = {
  '/Applications/Atom.app/Contents/MacOS/Atom': 'atom',
  '/Applications/Atom Beta.app/Contents/MacOS/Atom Beta': '/Applications/Atom Beta.app/Contents/MacOS/Atom Beta',
  '/Applications/Sublime Text.app/Contents/MacOS/Sublime Text': '/Applications/Sublime Text.app/Contents/SharedSupport/bin/subl',
  '/Applications/Sublime Text 2.app/Contents/MacOS/Sublime Text 2': '/Applications/Sublime Text 2.app/Contents/SharedSupport/bin/subl',
  '/Applications/Visual Studio Code.app/Contents/MacOS/Electron': 'code',
};

const COMMON_EDITORS_WIN = [
  'Code.exe',
  'atom.exe',
  'sublime_text.exe',
  'notepad++.exe',
];

If your favorite editor isn't in the list, but supports running from the command line with a line number, send a PR to launchEditor.js adding it to the list, and specifying its argument format.

To verify your change works, edit node_modules/react-dev-utils/launchEditor.js in your project, add a throw new Error('hi') to a component, and then verify that clicking on the error overlay takes you to the right place.

[Jan Nicklas]

This feature is really cool - you should create an independent npm package out of that! 👍

[dan]

Agree, we should extract it at some point! It's originally forked from React Native but we added more features and might eventually make RN depend on it.

[Nathaniel Tucker]

why no linux? :(

[dan]

@ntucker Because nobody contributed Linux support yet. Would you like to do that?

[Mikhail Osher]

In my opninion, WebStorm,PhpStorm and Idea should also be there. Despite the fact that JetBrains IDEs are offering to create a shortcut, still not a lot of people do it.

[dan]

Happy to take PRs!

[Buns Shar]

@gaearon I would like to contributed Linux support. Should I create another ticket?

[dan]

@bunshar This ticket is fine—just send a PR!

[Anup]

@gaearon in OSX you can launch Atom Beta using atom-beta command.

So,

  '/Applications/Atom Beta.app/Contents/MacOS/Atom Beta': '/Applications/Atom Beta.app/Contents/MacOS/Atom Beta',

can be

  '/Applications/Atom Beta.app/Contents/MacOS/Atom Beta': 'atom-beta',

[dan]

Happy to take PRs (although if it works fine, I wouldn't change it).

[Anup]

Can I take this up and add Linux support as well?

Sent from my OnePlus ONEPLUS A3003 using FastHub

[dan]

Sure.

[Anup]

@gaearon for opening CRA project in Visual Studio Code, we cannot use code as mentioned here unless we go and install the command line tools from the command pallet in VS Code.

Please find the documentation for setting up VS Code here

[Adrien Denat]

@reznord thanks, I just spent an hour debugging this and figured out it wasn't working because I didn't have the vscode CLI tool installed. :)
@gaearon are you open to PR to improve the error message? It would be cool if it was telling to VSCode users to install the CLI first if the code command is not found.

[stale]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs.