facebookincubator / FioSynth

Tool which enables the creation of synthetic storage workloads, automates the execution and results collection of synthetic storage benchmarks.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

TrimRate tests throttles scale when capacity is specified

jmazzie opened this issue · comments

I was running fiosynth and noticed that my performance while running the TrimRate tests were above the throttled limit based on the test suite configuration. I figured out that this was due to me specifying the capacity of the device using the -c flag. I've worked around the issue by not specifying the capacity, but believe the issue can be fixed in fiosynth.py, if this wasn't intended.

In the prepServers function the logic to check if a test scales by the factor could be moved up a level. This way it only uses a capacity factor if the test is supposed to scale with capacity. Currently it checks if you've specified a capacity first and if you do it always will scale any scalable variables in a test.

I would submit a PR myself, but cannot currently sign the contributor license due to company policy.

Proposed modification of code (lines 643 to 649 of fiosynth.py):

if (profile['scale_by_capacity'] != 'N'):
    if args.factor <= 0.0:
         dut.factor = getMultiplier(dut.capacity)
    else:
         dut.factor = args.factor
else:
    dut.factor = 1.0