Giters

facebookincubator / FBX2glTF

A command-line tool for the conversion of 3D model assets on the FBX file format to the glTF file format.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Leaking FILE Pointers in Image_Utils.cpp

fdinath opened this issue · comments

commented

If you try to convert a large FBX file, it will eventually fail because too many files have been opened. I tracked this down to src\utils\Image_Utils.cpp, where GetImageProperties() never calls fclose().

Btw, it would be good practice to output errno in the future so it would have been more obvious why it was failing.

This is also the cause of this bug #159