Giters

facebookincubator / FBX2glTF

A command-line tool for the conversion of 3D model assets on the FBX file format to the glTF file format.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Integration Testing

ProjectBarks opened this issue · comments

commented

There is no way of comparing versions to see if the tool works. What might be useful is exporting some common FBX models then using a glTF validator to check that the file generated is valid.

commented

Hello! I moved the test suite elsewhere: https://github.com/zellski/FBX2glTF-Tests/

The main reason for the move was to rid this repository of Git LFS dependencies.

The suite does run the validator, but we ought to be doing much more — at minimum test generated GLB md5 hashes against known versions. But really we should run an offline render and compare images.

commented

I feel like MD5 would be an anti-pattern since its expected that glTF file changes as the exporter gets better.

should run an offline render and compare images.

Yeah that makes sense

commented

I feel like MD5 would be an anti-pattern since its expected that glTF file changes as the exporter gets better.

It's definitely a bit of a pain. The version I have running elsewhere (bizarrely, this is not the only glTF generation system I maintain) helps keep things slightly sane by calculating the MD5 only on the binary part of the asset (which changes less frequently), and additionally do basically a context diff of the glTF JSON part against a known "golden" copy.

So when you improve the exporter, your tests do fail, but they fail by showing you exactly how the output has changed since the previous version. It is then quite easy to update the "golden" copy as part of the commit. If the changes are even larger, you update the MD5 too, after having verified the asset is still good in more hands-on ways.