facebookarchive / xcbuild

Xcode-compatible build tool.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Dead code found by static analyzer?

QiAnXinCodeSafe opened this issue · comments

Hi all,
This is Qihoo360 CodeSafe Team, we found some dead code issues in xcbuild, see
https://github.com/facebook/xcbuild/blob/7787fa91cad6b3d9fa73d4293b4a31e5b59067e9/Libraries/acdriver/Sources/Compile/Convert.cpp#L78. The line 81 and 84 are also dead code.

Can you guys help me to confirm this?

Thanks!

Yeah, a break after a return is dead code indeed...