facebookarchive / nifty

Thrift on Netty

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Channel Statistics

ann opened this issue · comments

What is the best way to expose Channel Statistics for gauging metrics (to ultimately log to Graphite)? Ideally, this would be implemented without modifying or duplicating existing Nifty classes.

This is currently not exposed, but we can probably add something. Currently each connection creates its own ChannelStatistics which is probably not great. You would probably prefer something that tracks bytes read/written for the whole server? And it would probably be better to track this using the stat-tracking classes that can give you bytes read/written in the last 1/5/15 minutes & all time?

Ideally this would be very basic so that the class calculates stats (e.g. number of channels and bytes transferred/received for the entire server) irrespective of time; something along the lines of Guava's CacheBuilder.recordStats()

@andrewcox What do you think about #86?

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.