facebookarchive / nifty

Thrift on Netty

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Upgrade to Netty 4

infynyxx opened this issue · comments

Netty 4 is nearing completion so, it would be lovely to see that up for use.

Is already being worked on

Sweet. Can't find that branch though.

Sorry I should have been more specific. There is no branch for it yet, but it's almost ready to go up. Just working out a few performance problems.

Most users of nifty / swift are still on netty 3.x. Unless we can ensure that netty 3 and netty 4 can co-exist, we need to publish two separate artifacts. I can a factoring out of a reasonable nifty API and then offer a n3 and n4 implementation but an unconditional switch would probably require shading in the netty dependency.

Netty 3 and 4 are in different packages (io.netty and org.jboss.netty) , so there should be no problem running them in the same VM.

https://github.com/andrewcox/nifty/tree/netty4
https://github.com/andrewcox/swift/tree/netty4

These branches build and pass all tests running on netty 4, will be cleaning up and make pull requests soon after netty 4 final is released.

notice pom netty dependency version is 4.0.0.CR1 ,have you test netty latest version,such as netty-4.0.12 final?

have Upgraded to Netty4 ?

https://github.com/andrewcox/nifty/tree/netty4
this branch is not using the stable version of netty 4 which is quite different and will lead the "java.lang.OutOfMemoryError: Java heap space" error.

@andrewcox are you still working on this ?
Seems there is no replacement solutions for using thrift on netty4 or netty5.

Still no plan for netty 4 yet?

I am working on this again. Here is my working branch that builds & verifies but needs lots of addressing todo items and some code cleanup.

https://github.com/andrewcox/nifty/tree/netty4.0.24

And also needs to be rebased to current changes

Any updates on finalizing the Netty 4 branch soon?

Anyone working on 4.1 ?

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

Any updates on this?

any updates?

any updates on this?

any updates on this?