facebookarchive / nifty

Thrift on Netty

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

NettyServerConfigBuilder instead of NettyConfigBuilder

reddragon opened this issue · comments

There is a small mistake on the README.md

    // Create the server transport
    final NettyServerTransport server = new NettyServerTransport(serverDef,
                                                                 new NettyConfigBuilder(),
                                                                 new DefaultChannelGroup(),
                                                                 new HashedWheelTimer());

replace by

    // Create the server transport
    final NettyServerTransport server = new NettyServerTransport(serverDef,
                                                                 new NettyServerConfigBuilder(),
                                                                 new DefaultChannelGroup(),
                                                                 new HashedWheelTimer());

I would accept a pull request :-)

Sure, will do :)

Are you synced to old sources? This is already renamed.

Oh duh, readme :)