Support AsyncDisplayNode
cfcommando opened this issue · comments
We'd like to test AsyncDisplayNode with snapshots.
At the very least, testing by synchronously forcing view/layer display should be workable?
Rendering synchronously sounds like it would work. Is this report regarding a particular bug?
No, but at reddit we're using ASDK and want to add UI testing to our apps as well, and since both are FB libraries, it'd be nice to have first-party support for testing ASDK with ios-shapshot-test-case. =)
Rendering synchronously should certainly work in theory. I think setting isSynchronous = YES; on everything during the test environment bring-up would work. There are quite a few priorities for ASDK right now and since we run on volunteered time, I don’t think the core group will get to “first-party” support anytime soon, but certainly if bugs are discovered with isSynchronous we can investigate!
Sounds good. If we have any issues using isSynchronous I'll update you, but it sounds like a workable approach.
thanks @cfcommando