Tests are failing since 1.2 with drawViewHierarchyInRect:afterScreenUpdates

Question

Tests are failing since 1.2 with drawViewHierarchyInRect:afterScreenUpdates

tapwork opened this issue 10 years ago · comments

Christian Menschel commented 10 years ago

Since release 1.2 and the changes with drawViewHierarchyInRect:afterScreenUpdates most of our tests are failing. Release 1.2 is not usable for us.
Why is drawViewHierarchyInRect:afterScreenUpdates necessary? Performance?

Felix Schulze · Answer 1 · Mon Sep 15 2014 22:35:58 GMT+0800 (China Standard Time)

The drawViewHierarchyInRect:afterScreenUpdates renders the view more like in real. But that means that they are not compatible to the old rendering.

I made a pull request (#46), which makes it possible to select between these two ways of rendering.

Jonathan Crooke · Answer 2 · Wed Sep 17 2014 01:09:55 GMT+0800 (China Standard Time)

Have just noticed this: definitely like that the new version can render content that previously didn't work (especially fonts in many cases), but I'm having the problem that even after updating my reference images I still don't get matches. Will check out the pull request. I think this may need to be optional with some kind of "high accuracy" mode...

Christian Menschel · Answer 3 · Thu Sep 18 2014 15:53:55 GMT+0800 (China Standard Time)

I came to the conclusion to adapt my tests to work with 1.2.
So I am fine with 1.2