facebookarchive / ios-snapshot-test-case

Snapshot view unit tests for iOS

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

iOS 7 support dropped without apparent compatibility issue?

appleguy opened this issue · comments

Hi all - and @nscoding, awesome handle! A recent commit, d7edace, bumped the minimum iOS version to 8.0 without details on why this change was made.

This prevents AsyncDisplayKit from updating our dependency, which is a bummer because we'd like to use some new improvements without forking.

If there is a reason why 7.0 adds inconvenience to the framework's maintenance, that's understandable. But when I check it out locally and make the change, nothing seems to break.

Any thoughts on whether this can be set back to 7.0 until a compatibility issue arises?

Hey thanks for opening this issue, my problem was validating the spec to the point that I couldn't push a version. I will investigate this week.

I had several validation issues with cocoapods but thankfully the latest prerelease allow me to validate a spec with iOS7.

  • October 6th, 14:50: Push for `FBSnapshotTestCase 2.1.4' initiated.
  • October 6th, 14:50: Push for `FBSnapshotTestCase 2.1.4' has been pushed (0.417551121 s).

Thank you Patrick!

On Oct 6, 2016, at 2:53 PM, Patrick Chamelo notifications@github.com wrote:

Closed #196 #196.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #196 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AAigAyWZOj3rCkBzlYpgjb2kwzdYBDNNks5qxW3rgaJpZM4KFx4q.