SWIFT_VERSION is missing from FBSnapshotTestCase.podspec

Question

SWIFT_VERSION is missing from FBSnapshotTestCase.podspec

nate-m opened this issue 8 years ago · comments

Xcode 8 is still complaining about Swift syntax. Can you please update the podspec to set the swift version? I can have Xcode update the config, but it gets overridden during the next pod install

Shagun Madhikarmi · Answer 1 · Mon Sep 26 2016 22:44:17 GMT+0800 (China Standard Time)

+1

I'm unable to install the library correctly using master or v2.1.3 via CocoaPods into a Swift 3 based project and running CocoaPods v1.1rc2

Results (after installing via 2.1.3)

Adam Gr · Answer 2 · Tue Sep 27 2016 01:38:36 GMT+0800 (China Standard Time)

@nate-m @madhikarma I suggest to don't use SwiftSupport subspec.
Thanks this PR you can add extension to FBSnapshotTestCase and write 3 more lines with error handling.

Shagun Madhikarmi · Answer 3 · Tue Sep 27 2016 01:49:55 GMT+0800 (China Standard Time)

Thanks! I'll give that a try. I was able to get it to install without syntax / build errors using

pod 'FBSnapshotTestCase', :git => 'git@github.com:facebook/ios-snapshot-test-case.git', :branch => 'swift-beta-3’

I'm not sure how far behind this branch is from master or why the pods install successfully from this branch (rather than from master)

Also have you seen the .swift-version file CocoaPods team added for listing swift 3.0 support in 1.1rc2? It might be worth trying to get the pod to install correctly from master now that Swift 3 code is merged there

On 26 Sep 2016, at 18:38, Adam Gr notifications@github.com wrote:

@nate-m @madhikarma I suggest to don't use SwiftSupport subspec.
Thanks this PR you can add extension to FBSnapshotTestCase and write 3 more lines with error handling.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Patrick Chamelo · Answer 4 · Fri Oct 07 2016 05:54:24 GMT+0800 (China Standard Time)

I just cut 2.1.4 supports Swift 3, can you give it a try?

Orta Therox · Answer 5 · Tue Nov 29 2016 21:59:04 GMT+0800 (China Standard Time)

We're using 2.1.4 and it's working 👍

You should be fine to close this issue

Carlos Pages · Answer 6 · Tue Mar 07 2017 00:34:27 GMT+0800 (China Standard Time)

@orta I'm using Using FBSnapshotTestCase (2.1.4) and Xcode 8.2.1 and it is still complaining about SwiftSupport.swift to convert it to swift 3.0.

Maybe it's me?

I got the error running fastlane scan, after using Xcode tool to convert SwiftSupport.swift to swift 3, it worked ( but obviously I changed one file in the pod so this will be reset to it original state )