facebookarchive / ios-snapshot-test-case

Snapshot view unit tests for iOS

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Branch or release for Swift 2.3

parski opened this issue · comments

Hello!

My team uses Nimble-Snapshots in our Swift 2.2 product and FBSnapshotTestCase is one of it's dependencies. We want to be able to build our product with Xcode 8 and since upgrading our code base to Swift 3.0 will be a large task we have decided to first upgrade it to Swift 2.3.

Can you make a release or branch from commit b48e77e3397298baf1532a8e4f418197df2843c3? I strongly dislike pointing to a commit in Podfiles and having a separate branch for Swift 2.3 would make our Podfile less of a chore to deal with.

hmm, the code on master at the moment has code for both >3 and 2.3 doesn't this work for you guys?

It works but the moment you commit to master our application might break. I would sleep a lot better knowing that I'm pointing to a release in my Podfile.

I just cut a spec:

  • September 22nd, 10:24: Push for `FBSnapshotTestCase 2.1.3' initiated.
  • September 22nd, 10:24: Push for `FBSnapshotTestCase 2.1.3' has been pushed (0.38892521 s).

@parski why you weren't able to use the latest code of this library after Swift 3 branch was merged in? It uses #if swift(>=3) and it should have been working with both Swift 2.3 and Swift 3.0