facebook / winterfell

A STARK prover and verifier for arbitrary computations

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

"Make sure layer queries hash into leaves of layer proof"

RobinLinus opened this issue · comments

In this line there's a TODO saying "make sure layer queries hash into leaves of layer proof". Sounds like the verifier currently does not verify that, or is it verified somewhere else?

This is more for a "debug" type check to make sure the code which actually computes hashes of leaves works correctly. The code that does this is located here.

I do think that this structure is more complicated than it needs to be and I'd love to refactor it at some point (i.e., by abstracting away Merkle trees behind a VectorCommitment trait).