Starlark update throws errors related to the Allocative trait.

Question

Starlark update throws errors related to the Allocative trait.

hulto opened this issue a year ago · comments

I'm working on updating to the latest version of starlark (acf6384) on the main branch so I can leverage the PrintHandle attribute and set a custom handler.

I was having some issues around allocative so I tried just building one of the example code sections but ran into the same compiler error.
https://github.com/facebookexperimental/starlark-rust/blob/acf638430a00ca3855862e8c669670e1adaa42aa/starlark/src/lib.rs#L287

I made some minor modifications like moving the struct definition and impl's out of the run function.

#![feature(trivial_bounds)]

use starlark::environment::{Globals, Module};
use starlark::eval::Evaluator;
use starlark::syntax::{AstModule, Dialect};
use starlark::values::{Heap, StarlarkValue, Value, ValueError, ValueLike, ProvidesStaticType, NoSerialize};
use starlark::{starlark_type, starlark_simple_value};
use std::fmt::{self, Display, Write};
use allocative::Allocative;

// Define complex numbers
#[derive(Debug, PartialEq, Eq, ProvidesStaticType, Allocative, NoSerialize)]
struct Complex {
    real: i32,
    imaginary: i32,
}
starlark_simple_value!(Complex);

impl Display for Complex {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        write!(f, "{} + {}i", self.real, self.imaginary)
    }
}

impl<'v> StarlarkValue<'v> for Complex {
    starlark_type!("complex");

    // How we add them
    fn add(&self, rhs: Value<'v>, heap: &'v Heap)
            -> Option<anyhow::Result<Value<'v>>> {
        if let Some(rhs) = rhs.downcast_ref::<Self>() {
            Some(Ok(heap.alloc(Complex {
                real: self.real + rhs.real,
                imaginary: self.imaginary + rhs.imaginary,
            })))
        } else {
            None
        }
    }
}

fn run() -> anyhow::Result<()> {
    let content = "str(a + b)";

    let ast = AstModule::parse("complex.star", content.to_owned(), &Dialect::Standard)?;
    let globals = Globals::standard();
    let module = Module::new();
    // We inject some complex numbers into the module before we start.
    let a = module.heap().alloc(Complex {real: 1, imaginary: 8});
    module.set("a", a);
    let b = module.heap().alloc(Complex {real: 4, imaginary: 2});
    module.set("b", b);
    let mut eval = Evaluator::new(&module);
    let res = eval.eval_module(ast, &globals)?;
    assert_eq!(res.unpack_str(), Some("5 + 10i"));
    Ok(())
}
fn main(){ run().unwrap(); }

When building the project I get an error that the Allocative trait is not implemented for the Complex struct.

Downloads/starlark-test/starlark-test-proj  🦀 1.70.0-nightly   master ✘ ✭ 
$ cargo run
   Compiling rustix v0.36.11
   Compiling terminal_size v0.2.5
   Compiling clap_builder v4.2.1
   Compiling clap v4.2.1
   Compiling starlark v0.9.0-pre (https://github.com/facebookexperimental/starlark-rust?rev=acf638430a00ca3855862e8c669670e1adaa42aa#acf63843)
   Compiling starlark-test-proj v0.1.0 (/Users/hulto/Downloads/starlark-test/starlark-test-proj)
warning: unused import: `ValueError`
 --> src/main.rs:6:52
  |
6 | use starlark::values::{Heap, StarlarkValue, Value, ValueError, ValueLike, ProvidesStaticType, NoSerialize};
  |                                                    ^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

error[E0277]: the trait bound `Complex: allocative::allocative_trait::Allocative` is not satisfied
   --> src/main.rs:25:32
    |
25  | impl<'v> StarlarkValue<'v> for Complex {
    |                                ^^^^^^^ the trait `allocative::allocative_trait::Allocative` is not implemented for `Complex`
    |
    = help: the following other types implement trait `allocative::allocative_trait::Allocative`:
              !
              &'static T
              ()
              (A, B)
              (A, B, C)
              (A, B, C, D)
              (A, B, C, D, E)
              (A,)
            and 118 others
note: required by a bound in `StarlarkValue`
   --> /Users/hulto/.cargo/git/checkouts/starlark-rust-59575ffdf833204c/acf6384/starlark/src/values/traits.rs:206:31
    |
206 |     'v + ProvidesStaticType + Allocative + Debug + Display + Serialize + Sized
    |                               ^^^^^^^^^^ required by this bound in `StarlarkValue`

For more information about this error, try `rustc --explain E0277`.
warning: `starlark-test-proj` (bin "starlark-test-proj") generated 1 warning
error: could not compile `starlark-test-proj` (bin "starlark-test-proj") due to previous error; 1 warning emitted

I tried implementing the Allocative trait manually instead of through a derive but got the same error.

Doing both, defining the Allocative trait manuallly and through derive throws an error that Allocative is defined twice.

cargo version
cargo 1.70.0-nightly (145219a9f 2023-03-27)

Cargo.toml

[dependencies]
starlark = { git = "https://github.com/facebookexperimental/starlark-rust", rev = "acf638430a00ca3855862e8c669670e1adaa42aa" }
allocative = { version = "0.2" }
allocative_derive = { version = "0.2" }
anyhow = "1.0.65"

Stepan Koltsov · Answer 1 · Sun Apr 02 2023 11:18:07 GMT+0800 (China Standard Time)

Just derive(Allocative) should be sufficient.

Check cargo tree please, do you have the same version of allocative in starlark dependency and in your crate dependency?

Hulto · Answer 2 · Mon Apr 03 2023 02:45:35 GMT+0800 (China Standard Time)

I think the versions in my crate & Starlark are the same.
I'm not vendoring the allocative crate though.

starlark-test-proj v0.1.0 (/Users/hulto/Downloads/starlark-test/starlark-test-proj)
├── allocative v0.2.0
│   └── allocative_derive v0.2.0 (proc-macro)
│       ├── proc-macro2 v1.0.54
│       │   └── unicode-ident v1.0.8
│       ├── quote v1.0.26
│       │   └── proc-macro2 v1.0.54 (*)
│       └── syn v1.0.109
│           ├── proc-macro2 v1.0.54 (*)
│           ├── quote v1.0.26 (*)
│           └── unicode-ident v1.0.8
├── allocative_derive v0.2.0 (proc-macro) (*)
├── anyhow v1.0.70
└── starlark v0.9.0-pre (https://github.com/facebookexperimental/starlark-rust?rev=acf638430a00ca3855862e8c669670e1adaa42aa#acf63843)
    ├── allocative v0.2.0 (https://github.com/facebookexperimental/starlark-rust?rev=acf638430a00ca3855862e8c669670e1adaa42aa#acf63843)
    │   ├── allocative_derive v0.2.0 (proc-macro) (https://github.com/facebookexperimental/starlark-rust?rev=acf638430a00ca3855862e8c669670e1adaa42aa#acf63843)
    │   │   ├── proc-macro2 v1.0.54 (*)
    │   │   ├── quote v1.0.26 (*)
    │   │   └── syn v1.0.109 (*)
    │   ├── bumpalo v3.12.0
    │   ├── ctor v0.1.26 (proc-macro)
    │   │   ├── quote v1.0.26 (*)
    │   │   └── syn v1.0.109 (*)
    │   ├── hashbrown v0.12.3
    │   │   └── ahash v0.7.6
    │   │       ├── getrandom v0.2.8
    │   │       │   ├── cfg-if v1.0.0
    │   │       │   └── libc v0.2.140
    │   │       └── once_cell v1.17.1
    │   │       [build-dependencies]
    │   │       └── version_check v0.9.4
    │   └── num-bigint v0.4.3
    │       ├── num-integer v0.1.45
    │       │   └── num-traits v0.2.15
    │       │       [build-dependencies]
    │       │       └── autocfg v1.1.0
    │       │   [build-dependencies]
    │       │   └── autocfg v1.1.0
    │       └── num-traits v0.2.15 (*)
    │       [build-dependencies]
    │       └── autocfg v1.1.0
    ├── annotate-snippets v0.9.1
    │   └── unicode-width v0.1.10
    ├── anyhow v1.0.70
    ├── argfile v0.1.5
    │   └── os_str_bytes v6.5.0
    │       └── memchr v2.5.0
    ├── bumpalo v3.12.0
    ├── clap v4.2.1
    │   ├── clap_builder v4.2.1
    │   │   ├── anstream v0.2.6
    │   │   │   ├── anstyle v0.3.5
    │   │   │   ├── anstyle-parse v0.1.1
    │   │   │   │   └── utf8parse v0.2.1
    │   │   │   ├── concolor-override v1.0.0
    │   │   │   ├── concolor-query v0.3.3
    │   │   │   ├── is-terminal v0.4.6
    │   │   │   │   ├── io-lifetimes v1.0.9
    │   │   │   │   │   └── libc v0.2.140
    │   │   │   │   └── rustix v0.37.5
    │   │   │   │       ├── bitflags v1.3.2
    │   │   │   │       ├── errno v0.3.0
    │   │   │   │       │   └── libc v0.2.140
    │   │   │   │       ├── io-lifetimes v1.0.9 (*)
    │   │   │   │       └── libc v0.2.140
    │   │   │   └── utf8parse v0.2.1
    │   │   ├── anstyle v0.3.5
    │   │   ├── bitflags v1.3.2
    │   │   ├── clap_lex v0.4.1
    │   │   ├── strsim v0.10.0
    │   │   └── terminal_size v0.2.5
    │   │       └── rustix v0.36.11
    │   │           ├── bitflags v1.3.2
    │   │           ├── errno v0.2.8
    │   │           │   └── libc v0.2.140
    │   │           ├── io-lifetimes v1.0.9 (*)
    │   │           └── libc v0.2.140
    │   ├── clap_derive v4.2.0 (proc-macro)
    │   │   ├── heck v0.4.1
    │   │   ├── proc-macro2 v1.0.54 (*)
    │   │   ├── quote v1.0.26 (*)
    │   │   └── syn v2.0.11
    │   │       ├── proc-macro2 v1.0.54 (*)
    │   │       ├── quote v1.0.26 (*)
    │   │       └── unicode-ident v1.0.8
    │   └── once_cell v1.17.1
    ├── debugserver-types v0.5.0
    │   ├── schemafy v0.5.2 (proc-macro)
    │   │   ├── Inflector v0.11.4
    │   │   │   ├── lazy_static v1.4.0
    │   │   │   └── regex v1.7.3
    │   │   │       ├── aho-corasick v0.7.20
    │   │   │       │   └── memchr v2.5.0
    │   │   │       ├── memchr v2.5.0
    │   │   │       └── regex-syntax v0.6.29
    │   │   ├── schemafy_core v0.5.2
    │   │   │   ├── serde v1.0.159
    │   │   │   │   └── serde_derive v1.0.159 (proc-macro)
    │   │   │   │       ├── proc-macro2 v1.0.54 (*)
    │   │   │   │       ├── quote v1.0.26 (*)
    │   │   │   │       └── syn v2.0.11 (*)
    │   │   │   └── serde_json v1.0.95
    │   │   │       ├── itoa v1.0.6
    │   │   │       ├── ryu v1.0.13
    │   │   │       └── serde v1.0.159 (*)
    │   │   ├── schemafy_lib v0.5.2
    │   │   │   ├── Inflector v0.11.4 (*)
    │   │   │   ├── proc-macro2 v1.0.54 (*)
    │   │   │   ├── quote v1.0.26 (*)
    │   │   │   ├── schemafy_core v0.5.2 (*)
    │   │   │   ├── serde v1.0.159 (*)
    │   │   │   ├── serde_derive v1.0.159 (proc-macro) (*)
    │   │   │   ├── serde_json v1.0.95 (*)
    │   │   │   └── syn v1.0.109 (*)
    │   │   ├── serde v1.0.159 (*)
    │   │   ├── serde_derive v1.0.159 (proc-macro) (*)
    │   │   ├── serde_json v1.0.95 (*)
    │   │   ├── serde_repr v0.1.12 (proc-macro)
    │   │   │   ├── proc-macro2 v1.0.54 (*)
    │   │   │   ├── quote v1.0.26 (*)
    │   │   │   └── syn v2.0.11 (*)
    │   │   └── syn v1.0.109 (*)
    │   ├── serde v1.0.159 (*)
    │   └── serde_json v1.0.95 (*)
    ├── derivative v2.2.0 (proc-macro)
    │   ├── proc-macro2 v1.0.54 (*)
    │   ├── quote v1.0.26 (*)
    │   └── syn v1.0.109 (*)
    ├── derive_more v0.99.17 (proc-macro)
    │   ├── convert_case v0.4.0
    │   ├── proc-macro2 v1.0.54 (*)
    │   ├── quote v1.0.26 (*)
    │   └── syn v1.0.109 (*)
    │   [build-dependencies]
    │   └── rustc_version v0.4.0
    │       └── semver v1.0.17
    ├── dupe v0.8.1 (https://github.com/facebookexperimental/starlark-rust?rev=acf638430a00ca3855862e8c669670e1adaa42aa#acf63843)
    │   └── dupe_derive v0.8.0 (proc-macro) (https://github.com/facebookexperimental/starlark-rust?rev=acf638430a00ca3855862e8c669670e1adaa42aa#acf63843)
    │       ├── proc-macro2 v1.0.54 (*)
    │       ├── quote v1.0.26 (*)
    │       └── syn v1.0.109 (*)
    ├── either v1.8.1
    ├── erased-serde v0.3.25
    │   └── serde v1.0.159 (*)
    ├── fancy-regex v0.10.0
    │   ├── bit-set v0.5.3
    │   │   └── bit-vec v0.6.3
    │   └── regex v1.7.3 (*)
    ├── gazebo v0.8.1 (https://github.com/facebookexperimental/starlark-rust?rev=acf638430a00ca3855862e8c669670e1adaa42aa#acf63843)
    │   ├── dupe v0.8.1 (https://github.com/facebookexperimental/starlark-rust?rev=acf638430a00ca3855862e8c669670e1adaa42aa#acf63843) (*)
    │   └── gazebo_derive v0.8.0 (proc-macro) (https://github.com/facebookexperimental/starlark-rust?rev=acf638430a00ca3855862e8c669670e1adaa42aa#acf63843)
    │       ├── proc-macro2 v1.0.54 (*)
    │       ├── quote v1.0.26 (*)
    │       └── syn v1.0.109 (*)
    ├── hashbrown v0.12.3 (*)
    ├── inventory v0.1.11
    │   ├── ctor v0.1.26 (proc-macro) (*)
    │   ├── ghost v0.1.9 (proc-macro)
    │   │   ├── proc-macro2 v1.0.54 (*)
    │   │   ├── quote v1.0.26 (*)
    │   │   └── syn v2.0.11 (*)
    │   └── inventory-impl v0.1.11 (proc-macro)
    │       ├── proc-macro2 v1.0.54 (*)
    │       ├── quote v1.0.26 (*)
    │       └── syn v1.0.109 (*)
    ├── itertools v0.10.5
    │   └── either v1.8.1
    ├── lalrpop-util v0.19.9
    ├── logos v0.12.1
    │   └── logos-derive v0.12.1 (proc-macro)
    │       ├── beef v0.5.2
    │       ├── fnv v1.0.7
    │       ├── proc-macro2 v1.0.54 (*)
    │       ├── quote v1.0.26 (*)
    │       ├── regex-syntax v0.6.29
    │       └── syn v1.0.109 (*)
    ├── lsp-server v0.5.2
    │   ├── crossbeam-channel v0.5.7
    │   │   ├── cfg-if v1.0.0
    │   │   └── crossbeam-utils v0.8.15
    │   │       └── cfg-if v1.0.0
    │   ├── log v0.4.17
    │   │   └── cfg-if v1.0.0
    │   ├── serde v1.0.159 (*)
    │   └── serde_json v1.0.95 (*)
    ├── lsp-types v0.93.2
    │   ├── bitflags v1.3.2
    │   ├── serde v1.0.159 (*)
    │   ├── serde_json v1.0.95 (*)
    │   ├── serde_repr v0.1.12 (proc-macro) (*)
    │   └── url v2.3.1
    │       ├── form_urlencoded v1.1.0
    │       │   └── percent-encoding v2.2.0
    │       ├── idna v0.3.0
    │       │   ├── unicode-bidi v0.3.13
    │       │   └── unicode-normalization v0.1.22
    │       │       └── tinyvec v1.6.0
    │       │           └── tinyvec_macros v0.1.1
    │       ├── percent-encoding v2.2.0
    │       └── serde v1.0.159 (*)
    ├── maplit v1.0.2
    ├── memchr v2.5.0
    ├── memoffset v0.6.5
    │   [build-dependencies]
    │   └── autocfg v1.1.0
    ├── num-bigint v0.4.3 (*)
    ├── num-traits v0.2.15 (*)
    ├── once_cell v1.17.1
    ├── paste v1.0.12 (proc-macro)
    ├── regex v1.7.3 (*)
    ├── rustyline v7.1.0
    │   ├── bitflags v1.3.2
    │   ├── cfg-if v1.0.0
    │   ├── dirs-next v2.0.0
    │   │   ├── cfg-if v1.0.0
    │   │   └── dirs-sys-next v0.1.2
    │   │       └── libc v0.2.140
    │   ├── fs2 v0.4.3
    │   │   └── libc v0.2.140
    │   ├── libc v0.2.140
    │   ├── log v0.4.17 (*)
    │   ├── memchr v2.5.0
    │   ├── nix v0.19.1
    │   │   ├── bitflags v1.3.2
    │   │   ├── cfg-if v1.0.0
    │   │   └── libc v0.2.140
    │   ├── unicode-segmentation v1.10.1
    │   ├── unicode-width v0.1.10
    │   └── utf8parse v0.2.1
    ├── serde v1.0.159 (*)
    ├── serde_json v1.0.95 (*)
    ├── starlark_derive v0.9.0-pre (proc-macro) (https://github.com/facebookexperimental/starlark-rust?rev=acf638430a00ca3855862e8c669670e1adaa42aa#acf63843)
    │   ├── dupe v0.8.1 (https://github.com/facebookexperimental/starlark-rust?rev=acf638430a00ca3855862e8c669670e1adaa42aa#acf63843) (*)
    │   ├── gazebo v0.8.1 (https://github.com/facebookexperimental/starlark-rust?rev=acf638430a00ca3855862e8c669670e1adaa42aa#acf63843) (*)
    │   ├── proc-macro2 v1.0.54 (*)
    │   ├── quote v1.0.26 (*)
    │   └── syn v1.0.109 (*)
    ├── starlark_map v0.9.0-pre (https://github.com/facebookexperimental/starlark-rust?rev=acf638430a00ca3855862e8c669670e1adaa42aa#acf63843)
    │   ├── allocative v0.2.0 (https://github.com/facebookexperimental/starlark-rust?rev=acf638430a00ca3855862e8c669670e1adaa42aa#acf63843) (*)
    │   ├── dupe v0.8.1 (https://github.com/facebookexperimental/starlark-rust?rev=acf638430a00ca3855862e8c669670e1adaa42aa#acf63843) (*)
    │   ├── fnv v1.0.7
    │   ├── gazebo v0.8.1 (https://github.com/facebookexperimental/starlark-rust?rev=acf638430a00ca3855862e8c669670e1adaa42aa#acf63843) (*)
    │   └── hashbrown v0.12.3 (*)
    ├── static_assertions v1.1.0
    ├── strsim v0.10.0
    ├── textwrap v0.11.0
    │   └── unicode-width v0.1.10
    ├── thiserror v1.0.40
    │   └── thiserror-impl v1.0.40 (proc-macro)
    │       ├── proc-macro2 v1.0.54 (*)
    │       ├── quote v1.0.26 (*)
    │       └── syn v2.0.11 (*)
    └── walkdir v2.3.3
        └── same-file v1.0.6
    [build-dependencies]
    └── lalrpop v0.19.9
        ├── ascii-canvas v3.0.0
        │   └── term v0.7.0
        │       └── dirs-next v2.0.0 (*)
        ├── bit-set v0.5.3
        │   └── bit-vec v0.6.3
        ├── diff v0.1.13
        ├── ena v0.14.2
        │   └── log v0.4.17 (*)
        ├── is-terminal v0.4.6 (*)
        ├── itertools v0.10.5
        │   └── either v1.8.1
        ├── lalrpop-util v0.19.9
        │   └── regex v1.7.3 (*)
        ├── petgraph v0.6.3
        │   ├── fixedbitset v0.4.2
        │   └── indexmap v1.9.3
        │       └── hashbrown v0.12.3
        │       [build-dependencies]
        │       └── autocfg v1.1.0
        ├── pico-args v0.4.2
        ├── regex v1.7.3 (*)
        ├── regex-syntax v0.6.29
        ├── string_cache v0.8.7
        │   ├── new_debug_unreachable v1.0.4
        │   ├── once_cell v1.17.1
        │   ├── parking_lot v0.12.1
        │   │   ├── lock_api v0.4.9
        │   │   │   └── scopeguard v1.1.0
        │   │   │   [build-dependencies]
        │   │   │   └── autocfg v1.1.0
        │   │   └── parking_lot_core v0.9.7
        │   │       ├── cfg-if v1.0.0
        │   │       ├── libc v0.2.140
        │   │       └── smallvec v1.10.0
        │   ├── phf_shared v0.10.0
        │   │   └── siphasher v0.3.10
        │   └── precomputed-hash v0.1.1
        ├── term v0.7.0 (*)
        ├── tiny-keccak v2.0.2
        │   └── crunchy v0.2.2
        └── unicode-xid v0.2.4

Stepan Koltsov · Answer 3 · Mon Apr 03 2023 02:50:03 GMT+0800 (China Standard Time)

cargo tree output shows they are not the same: there are two versions: allocative v0.2.0 and allocative v0.2.0 (https://github.com/facebookexperimental/starlark-rust?rev=acf638430a00ca3855862e8c669670e1adaa42aa#acf63843).

To fix it, you need to tell Cargo to take allocative from starlark-rust repo.

(Also we should release new starlark-rust).

Hulto · Answer 4 · Mon Apr 03 2023 03:00:20 GMT+0800 (China Standard Time)

Ah! Awesome thank you 🙂

Hulto · Answer 5 · Mon Apr 03 2023 06:09:22 GMT+0800 (China Standard Time)

Updated cargo file.
Old

[dependencies]
starlark = { git = "https://github.com/facebookexperimental/starlark-rust", rev = "acf638430a00ca3855862e8c669670e1adaa42aa" }
allocative = { version = "0.2" }
allocative_derive = { version = "0.2" }
anyhow = "1.0.65"

New

[dependencies]
starlark = { git = "https://github.com/facebookexperimental/starlark-rust", rev = "acf638430a00ca3855862e8c669670e1adaa42aa" }
allocative = { git = "https://github.com/facebookexperimental/starlark-rust", rev = "acf638430a00ca3855862e8c669670e1adaa42aa" }
allocative_derive = { git = "https://github.com/facebookexperimental/starlark-rust", rev = "acf638430a00ca3855862e8c669670e1adaa42aa" }
anyhow = "1.0.65"