facebook / starlark-rust

A Rust implementation of the Starlark language

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Removing autocomplete triggers breaks autocomplete

cameron-martin opened this issue · comments

4be1b3b removes some autocomplete triggers. However, this breaks autocomplete for labels in vscode.

Before this commit, I could hit ctrl+space in a string and get autocomplete suggestions from the language server:

image

However, after this change I only get the default vscode autocomplete:

image

I believe the issue here is we're now sending None as completion_provider, which tells the client that the server does not support autocomplete. Instead it should be something like Some(CompletionOptions::default()).