facebook / starlark-rust

A Rust implementation of the Starlark language

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix Nightly Build (upgrade hashbrown)

KCarretto opened this issue · comments

Problem Overview

  • hashbrown v0.12.3 (currently locked to) depends on ahash v0.7.7
  • ahash v0.7.7 no longer builds on nightly-2024-02-06 due to the feature stdsimd being removed (see this issue)
error[E0635]: unknown feature `stdsimd`
  --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/ahash-0.7.7/src/lib.rs:33:42
   |
33 | #![cfg_attr(feature = "stdsimd", feature(stdsimd))]
   |  

Requested Solution

  • Upgrade hashbrown dependency to v0.14.3

@dtolnay is already working on the upgrade

Fixed in main. @wendy728 would you take care of publishing a release to crates.io? The most recent starlark release still has a dependency on hashbrown 0.12.3 so it's still broken.