Review Stack doesn't show the commit/PR stack
zcin opened this issue · comments
I have a stack of dummy PRs created through sapling:
However the corresponding review stack URLs don't show the "pull request X out of 3" dropdown. It only shows a "version" and commit dropdown, e.g. see the third PR. So I can't see the changes between PRs.
On the docs it says that ReviewStack will recognize PR stacks made from sapling, I created these PRs from sl pr submit --draft.
Sapling version: 0.2.20240116-133042+8acecb66
I just ran into the same issue as well.
I think it has to do with the [//]: # (BEGIN SAPLING FOOTER) textual marker introduced in #779. After removing that line manually from the PR description, Review Stack was able to correctly recognize the PR stack.
Thanks @horizon-blue, the manual fix also works for me. Have you figured out how to fix this without having to delete that line manually each time?
Looks like it can be fixed by updating saplingStack.ts in the ReviewStack codebase.
There are already unit tests, so it should be straightforward to fix TDD-style.
I took a stab at #837, but I cannot get it to build. I'm guessing it might be due to 8bc196d.
I see the autodeployment has also been failing: https://github.com/facebook/sapling/actions/workflows/reviewstack.dev-deploy.yml
I see the autodeployment has also been failing: https://github.com/facebook/sapling/actions/workflows/reviewstack.dev-deploy.yml
Looks like this has now been fixed: https://github.com/facebook/sapling/actions/workflows/reviewstack.dev-deploy.yml