facebook / sapling

A Scalable, User-Friendly Source Control System.

Home Page:https://sapling-scm.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Support py3.12

chenrui333 opened this issue · comments

Looks like the project does not work for py3.12, this is the crash log

(lldb) target create "/opt/homebrew/Cellar/sapling/0.2.20231113-145254-995db0d6/bin/sl"
Current executable set to '/opt/homebrew/Cellar/sapling/0.2.20231113-145254-995db0d6/bin/sl' (arm64).
(lldb) run
Process 14899 launched: '/opt/homebrew/Cellar/sapling/0.2.20231113-145254-995db0d6/bin/sl' (arm64)
Process 14899 stopped
* thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x10)
    frame #0: 0x0000000105ab83b0 Python`_PyObject_Malloc + 40
Python`:
->  0x105ab83b0 <+40>: ldr    x20, [x8, #0x10]
    0x105ab83b4 <+44>: adrp   x21, 975
    0x105ab83b8 <+48>: add    x21, x21, #0x910          ; _PyRuntime
    0x105ab83bc <+52>: ldr    x8, [x21, #0x30]
Target 0: (sl) stopped.

this is my build log, https://gist.github.com/chenrui333/a8d3dc3f8bd80e9226fc14118b87ca53

Thanks for reporting. We will get to this eventually when we upgrade Python internally, but it isn't a priority right now.