Giters

facebook / sapling

A Scalable, User-Friendly Source Control System.

Home Page:https://sapling-scm.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

bug(goto): cannot goto bookmark with a dash "-" in it

vegerot opened this issue · comments

commented

Steps to reproduce

  1. sl clone git@github.com:vegerot/proxy-audio-device.git
  2. sl goto proxy-audio-device-cli

Expected: should pull and switch to remote bookmark proxy-audio-device-cli

Actual:

$ sl goto "proxy-audio-device-cli"
abort: unknown revision 'proxy'!

Workaround:

$ sl goto "default/proxy-audio-device-cli"
pulling 'proxy-audio-device-cli' from 'ssh://git@github.com/vegerot/proxy-audio-device.git'
pulling 'proxy' from 'ssh://git@github.com/vegerot/proxy-audio-device.git'
abort: unknown revision 'default/proxy'!

$ sl web

# then, switch to the bookmark in the web UI
commented

This affects bookmarked commits in the ISL as well (since the ISL defaults to going to the bookmark over the commit). So once a commit in the ISL gets a hyphen in it, you can't use the ISL to get to it anymore.

commented

One way to work around this is to use sl bookmark --remote to find the branch you want to goto and then use sl goto hash where hash is the hash of the branch you are moving to.

commented

I'm confused because:

  1. This seems to be fixed now. Both in the ISL and with sl goto <bookmark>
  2. I'm on a version of Sapling that is dated BEFORE I chimed in last week (0.2.20240219-172743+3e819974)

shrug

Either way, if someone fixed this, thanks!