facebook / sapling

A Scalable, User-Friendly Source Control System.

Home Page:https://sapling-scm.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[ISL] Layout shift when changing commits

alex-statsig opened this issue · comments

When switching to another commit, the layout shifts unpredictably for a few seconds, sometimes causing mistaken button presses. There's two main things I see contributing:

  1. The "You are here" / "You're moving here" badges. "You're moving here" appears immediately which is okay, but then "You are here" disappears a few seconds later, causing a layout shift at an unexpected time.
  2. Working tree (changed files) sometimes flickers to show some files during a checkout, even if the tree is clean before/after. This causes a much bigger vertical layout shift, and is probably the bigger issue.

I've definitely caught myself trying to open a PR while checking out another commit, and ended up accidentally clicking a different button, causing some issues.

This isn't a huge deal, but would be nice if the positioning was just more consistent, so just raising it to see if there's any thoughts on easy improvements

Example of #2 (note that some of these files were unchanged by either commit, likely changed in main in between):
Screenshot 2023-10-04 at 3 31 11 PM