facebook / sapling

A Scalable, User-Friendly Source Control System.

Home Page:https://sapling-scm.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[ISL] Cannot use "Amend" or "Amend & Submit" (or edit messages)

alex-statsig opened this issue · comments

Amending from the ISL tree view with new changes works, but amending via the "commit panel" does not always (I have noticed sometimes it does, not sure the exact repro steps).

The option to click the title/description and enter "Edit" mode is unavailable, and clicking "Amend" or "Amend and Submit" buttons in the bottom right do nothing.

Started happening in latest version (0.1.21), guessing its related to "Propagate unsaved edited commit messages when a commit is amended"

I'm seeing this too. I can edit each commit's title/description once, but after the commit is amended, I can no longer edit that commit's title or description.

Closing the ISL tab and reopening it lets me edit them again (still only once per commit).

commented

Thanks for reporting the issue. I can reproduce it, cc @evangrayk there seems a bug in latest version: no edit button for "SUMMARY" and "Amend" button in the bottom is not working.

Screenshot 2023-08-24 at 5 01 58 PM

Thanks for reporting this, it should be fixed in 3723dfc. We're publishing a new version of the vscode extension with this fix now.