[ISL] [VSCode] Missing finish edit button while editing commit description/title
equetzal opened this issue · comments
Context
When using the Interactive Smartlog, on the right panel we do have the option to edit either the Title of the commit or the Description of the PR:
Problem
The problem is that when you click on the pencil to edit, there's no other button to save the progress or the written description.
This is very problematic because even if we can edit the description in Github, if we later amend or rebase de commit and submit it again, then sapling will override the description of the PR with the regular 'title' as description, causing to dump the wrote description on Github.
This also happens with the titles, It's not being possible to save the title and then I'm needing to uncommit, re-commit with a more carefully crafted title, and then re-link the PR to the new commit to keep updating the PR with the new name.
This is happening on v0.1.20
I was seeing this on
v0.1.19
, but now onv0.1.20
I'm seeing an "Amend Message" button when I change the message but not the contentsPS: As a workaround, I was amending a small change (add a command), then removing it and amending again (rather than uncommitting which requires a new PR)
Huh, interesting. You're right, I had to remove the extension and reinstall it and now the 'Amend Message' button is also appearing. Not sure if the extension update went wrong.
Then I'll be closing the issue as this is now properly working. Thanks!