facebook / react

@feedthejim reported that disabling the "Break on Warning" feature does not update the backend settings (in memory, without a reload) for React Native:

I believe the new settings should be updated here:

react/packages/react-devtools-shared/src/backend/console.js

Lines 133 to 138 in 263cfa6

    
           // Settings may change after we've patched the console. 
        
           // Using a shared ref allows the patch function to read the latest values. 
        
           consoleSettingsRef.appendComponentStack = appendComponentStack; 
        
           consoleSettingsRef.breakOnConsoleErrors = breakOnConsoleErrors; 
        
           consoleSettingsRef.showInlineWarningsAndErrors = showInlineWarningsAndErrors; 
        
           consoleSettingsRef.hideConsoleLogsInStrictMode = hideConsoleLogsInStrictMode;

But it sounds like they aren't. We should investigate.

Passing off to @lunaruan who's already looking into console changes and recently modified this code.

I tested this an it seemed like all the settings were updating without an update for me. Does Jimmy have any more repro steps for this bug?

Let's close this since it seems to be working as designed. When he's back from PTO, @feedthejim can let us know if there's something we missed and we can re-open.

	// Settings may change after we've patched the console.
	// Using a shared ref allows the patch function to read the latest values.
	consoleSettingsRef.appendComponentStack = appendComponentStack;
	consoleSettingsRef.breakOnConsoleErrors = breakOnConsoleErrors;
	consoleSettingsRef.showInlineWarningsAndErrors = showInlineWarningsAndErrors;
	consoleSettingsRef.hideConsoleLogsInStrictMode = hideConsoleLogsInStrictMode;

DevTools: Backend console settings reportedly not synced to RN backend